[libcxx-commits] [PATCH] D108071: [libcxx] Improve testing in #ifdef.

[Albion Fung via Phabricator via libcxx-commits]

Conanap added a comment.

Sorry for the late reply! There were some internal discussions before we came to a conclusion.

While this patch works, `__LONG_DOUBLE_128__` should be defined (or at least we haven't hit a case where it's undefined), so we would prefer something similar:

  #if defined(__PPC__) && __LONG_DOUBLE_128__ && (!defined(__LONG_DOUBLE_IEEE128__) || !__LONG_DOUBLE_IEEE128__)

The compiler in question is indeed Clang.

I have a patch of the preferred implementation here: https://reviews.llvm.org/D108352

Thanks for the help!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108071/new/

https://reviews.llvm.org/D108071