[libcxx-commits] [PATCH] D108231: [NFC][SystemZ][z/OS] Run clang-format on libcxxabi/src/cxa_guard_impl.h

[Daniel McIntosh via Phabricator via libcxx-commits]

DanielMcIntosh-IBM added a comment.

In D108231#2950768 <https://reviews.llvm.org/D108231#2950768>, @ldionne wrote:

> I'd normally frown upon this since we generally don't clang-format whole files at once, but since the changes are pretty small, it might be OK to do that. But we definitely want to clang-format it right though.

I know we're supposed to make the whitespace/formatting changes "highly localized" to the area we're about to make changes to, but since I'm going to be making changes to %80 of the file anyways, leaving the nonconformant formatting in the remaining %20 felt rather silly. Was this the wrong decision? Is there ever a situation where running clang-format on a whole file like this is recommend?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108231/new/

https://reviews.llvm.org/D108231