[libcxx-commits] [PATCH] D107721: [libc++] [P1614] Implement std::pair::operator<=>
Kent Ross via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Aug 17 19:12:23 PDT 2021
mumbleskates updated this revision to Diff 367090.
mumbleskates marked 3 inline comments as done.
mumbleskates added a comment.
- update CREDITS.TXT
- updates re feedback
- always gate synth-three-way on concepts
- include synth_three_way.h in <compare>
- Actually don't include synth_three_way in <compare>; instead include the functionality for testing from where it is officially exposed
- rename concepts comparison.h to three_way_comparable.h
- fix alphabetization
- alphabetize more
- nits
- move the pair operator<=> test to the right folder
- delete unused include
- revert pair-specific changes
- implement std::tuple::operator<=>
- unwrap lambda
- add tests
- update tests
- much more compact tests!
- add tests for comparisons with unequal tuple size
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107721/new/
https://reviews.llvm.org/D107721
Files:
libcxx/include/CMakeLists.txt
libcxx/include/__compare/synth_three_way.h
libcxx/include/__concepts/three_way_comparable.h
libcxx/include/__utility/pair.h
libcxx/include/concepts
libcxx/include/module.modulemap
libcxx/include/utility
libcxx/test/libcxx/diagnostics/detail.headers/compare/synth_three_way.module.verify.cpp
libcxx/test/libcxx/diagnostics/detail.headers/concepts/three_way_comparable.module.verify.cpp
libcxx/test/libcxx/library/description/conventions/expos.only.func/synth_three_way.pass.cpp
libcxx/test/std/utilities/utility/pairs/pairs.spec/three_way_comparison.pass.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107721.367090.patch
Type: text/x-patch
Size: 20418 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210818/0d272d2e/attachment-0001.bin>
More information about the libcxx-commits
mailing list