[libcxx-commits] [PATCH] D108071: [libcxx] Improve testing in #ifdef.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp:95
 
-#if defined(__PPC__) && __LONG_DOUBLE_128__ && !__LONG_DOUBLE_IEEE128__
+#if defined(__PPC__) && defined(__LONG_DOUBLE_128__) && !defined(__LONG_DOUBLE_IEEE128__)
 //	For 128 bit long double implemented as 2 doubles on PowerPC,
----------------
Who sets the `__LONG_DOUBLE_128__` macro — some vendor's compiler?
Are you sure this doesn't need to be
```
#if defined(__PPC__) && (defined(__LONG_DOUBLE_128__) && __LONG_DOUBLE_128__) && !(defined(__LONG_DOUBLE_IEEE128__) && __LONG_DOUBLE_IEEE128__)
```
to deal with the (hypothetical but I-don't-know-if-impossible) case of either `__LONG_DOUBLE_128__` or `__LONG_DOUBLE_IEEE128__` being defined as `0`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108071/new/

https://reviews.llvm.org/D108071