[libcxx-commits] [PATCH] D107996: [libunwind] Rename UNW_ARM64_* to UNW_AARCH64_*

Thu Aug 12 23:58:10 PDT 2021

mstorsjo added a comment.

In D107996#2943065 <https://reviews.llvm.org/D107996#2943065>, @MaskRay wrote:

> In D107996#2943009 <https://reviews.llvm.org/D107996#2943009>, @mstorsjo wrote:
>
>>> Not sure keeping UNW_ARM64_* has any compatibility importance.
>>
>> There’s code using the llvm version of libunwind that expects these names, see e.g. https://source.winehq.org/git/wine.git/blob/6b58d34a625ffaad181a7316009398f3c6444181:/dlls/ntdll/unix/signal_arm64.c#l250.
>>
>> (Also, the same file, on lines 188-208, has a different codepath for setting registers with llvm’s libunwind, iirc because our context is opaque. The corresponding file for x86_64 also has that distinction, even if the enum names match there.)
>
> Can wine's `__APPLE__` code path be fixed to use `UNW_AARCH64_*` (`defined(UNW_AARCH64_X0)`) instead? :)

Hmm, as these are enums, not defines, the code can’t check that :-( I guess worst case it’d require a configure test to see what the libunwind actually provides.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107996/new/

https://reviews.llvm.org/D107996