[libcxx-commits] [PATCH] D107877: Add issue tracking for spaceship operator<=> implementation

[Kent Ross via Phabricator via libcxx-commits]

mumbleskates added inline comments.


================
Comment at: libcxx/docs/Status/Spaceship.rst:39-40
+
+(Note: files with required updates will contain the TODO at the beginning of the
+list item so they can be easily found via global search.)
+
----------------
Quuxplusone wrote:
> FWIW, I don't understand what this sentence means at all. I assume it was copied from somewhere else where its meaning is equally unclear.
> My guess is that it just means "When there's a TODO in the code, we'll mark it with a TODO comment." Which is pretty obvious.
Yeah this is all lifted from the Ranges one, which has one TODO item in it to add more tests when spaceship operator implementation increases. I can't think of anything that should go here now but it seems reasonable to leave a space for it.


================
Comment at: libcxx/docs/Status/SpaceshipPapers.csv:9
+`LWG3380 <https://wg21.link/LWG3380>`_,common_type and comparison categories,C++20,
+`LWG3395 <https://wg21.link/LWG3395>`_,Definition for three-way comparison needs to be updated,C++20,
----------------
Quuxplusone wrote:
> I don't understand what a `Status` of `C++20` means (as opposed to `|In Progress|`).
That's the literal status of the LWGs; I can go through this and see what parts of this we've done, not done, or haven't affected our lack of doing things yet instead


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107877/new/

https://reviews.llvm.org/D107877