[libcxx-commits] [PATCH] D107663: [libc++] Restore `basic_ios`'s implicit conversion to `bool` in C++03 mode.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D107663#2938517 <https://reviews.llvm.org/D107663#2938517>, @Quuxplusone wrote:

> Welp, obviously that broke the existing test that tests `!std::is_convertible<std::istream&, void*>`.
> So I propose we change the test, on the theory that "match libstdc++'s behavior exactly" is more important than "match libc++'s old behavior in some but not all obscure corner cases" (which is what I was trying to achieve with `operator const void*` in the original version of this PR). @ldionne, does this still seem reasonable to you?

Yes, that seems reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107663/new/

https://reviews.llvm.org/D107663