[libcxx-commits] [PATCH] D106703: [libunwind] adds a way to synthesise libgcc

Wed Aug 11 14:02:50 PDT 2021

beanz added a comment.

I agree with @compnerd that this would make more sense as a feature of the runtimes build directory since it is bringing together pieces from multiple runtimes (libunwind & compiler-rt).

================
Comment at: libunwind/CMakeLists.txt:82
 set(LIBUNWIND_GCC_TOOLCHAIN "" CACHE PATH "GCC toolchain for cross compiling.")
+set(LIBUNWIND_SYNTH_LIBGCC "" CACHE
+    STRING "Synthesises symbolic links for the libgcc family of libraries that point to libunwind and compiler-rt. This flag is only useful for distribution managers wanting to replace libgcc with libunwind, and should not be used by mainstream LLVM consumers. Requires LIBUNWIND_USE_COMPILER_RT=ON.")
----------------
I'm confused about this option. Is it a bool as documented, or a string as implemented? Please clarify.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106703/new/

https://reviews.llvm.org/D106703