[libcxx-commits] [PATCH] D103581: [libc++] [P1614] Implement std::compare_three_way_result[_t].

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 11 12:24:35 PDT 2021


cjdb accepted this revision.
cjdb added a comment.

Otherwise LGTM



================
Comment at: libcxx/include/__compare/compare_three_way_result.h:28
+struct _LIBCPP_HIDE_FROM_ABI __compare_three_way_result<_Tp, _Up, decltype(
+  declval<const remove_reference_t<_Tp>&>() <=> declval<const remove_reference_t<_Up>&>(), void()
+)> {
----------------
We can probably use that `__add_lvalue_reference_t<_Tp>` alias here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103581/new/

https://reviews.llvm.org/D103581



More information about the libcxx-commits mailing list