[libcxx-commits] [PATCH] D107877: Add issue tracking for spaceship operator<=> implementation

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 11 09:06:16 PDT 2021


Quuxplusone accepted this revision.
Quuxplusone added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/docs/Status/Spaceship.rst:39-40
+
+(Note: files with required updates will contain the TODO at the beginning of the
+list item so they can be easily found via global search.)
+
----------------
FWIW, I don't understand what this sentence means at all. I assume it was copied from somewhere else where its meaning is equally unclear.
My guess is that it just means "When there's a TODO in the code, we'll mark it with a TODO comment." Which is pretty obvious.


================
Comment at: libcxx/docs/Status/SpaceshipPapers.csv:9
+`LWG3380 <https://wg21.link/LWG3380>`_,common_type and comparison categories,C++20,
+`LWG3395 <https://wg21.link/LWG3395>`_,Definition for three-way comparison needs to be updated,C++20,
----------------
I don't understand what a `Status` of `C++20` means (as opposed to `|In Progress|`).


================
Comment at: libcxx/docs/index.rst:46-48
    Status/Ranges
    Status/Format
+   Status/Spaceship
----------------
It'd be nice to a-z these: Format, then Ranges, then Spaceship.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107877/new/

https://reviews.llvm.org/D107877



More information about the libcxx-commits mailing list