[libcxx-commits] [PATCH] D107663: [libc++] Restore `basic_ios`'s implicit conversion to `bool` in C++03 mode.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Aug 10 12:34:48 PDT 2021
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM with my suggested change applied. Let's also cherry-pick this onto `release/13.x` to avoid breaking people.
================
Comment at: libcxx/include/ios:614
+ _LIBCPP_INLINE_VISIBILITY
+ operator const void*() const {return fail() ? nullptr : this;}
+#else
----------------
efriedma wrote:
> The ancient standards actually specify `operator void*`, not `operator const void*`, but that probably doesn't matter.
Yeah, let's make this `operator void*` to match the C++03 spec.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107663/new/
https://reviews.llvm.org/D107663
More information about the libcxx-commits
mailing list