[libcxx-commits] [PATCH] D103466: [libc++][format] Adds char formatter.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 3 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_char.pass.cpp:174-175
+
+  static_assert(std::__format::__number_max == 2'147'483'647,
+                "Update the assert and the test.");
+  // Note the static_assert tests whether the arg-id is valid.
----------------
vitaut wrote:
> You already have this assert above.
True, but I like these kind of asserts closely "attached" to where they're needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103466/new/

https://reviews.llvm.org/D103466