[libcxx-commits] [PATCH] D107801: Remove unused include in <compare>.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 10 07:20:23 PDT 2021


Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

Sure, LGTM. For pre-C++20 headers I believe we still don't want to remove `#include`s this way, because someone in the wild might be relying on the `#include`. But for C++20 `<compare>` (and C++20 `<concepts>` we're going ahead and doing this, AFAIK.



================
Comment at: libcxx/CREDITS.TXT:160-163
+
+N: Zhihao Yuan
+E: lichray at gmail.com
+D: Standard compatibility fixes.
----------------
If you're trying to alphabetize the contributor list, this is laughably insufficient. ;) I recommend reverting this diff, but it doesn't really matter AFAIC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107801/new/

https://reviews.llvm.org/D107801



More information about the libcxx-commits mailing list