[libcxx-commits] [libcxx] bb2a92e - [libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 10 01:07:02 PDT 2021


Author: Martin Storsjö
Date: 2021-08-10T11:06:18+03:00
New Revision: bb2a92e66e042703fd13a82a7d5ea02fbbb01543

URL: https://github.com/llvm/llvm-project/commit/bb2a92e66e042703fd13a82a7d5ea02fbbb01543
DIFF: https://github.com/llvm/llvm-project/commit/bb2a92e66e042703fd13a82a7d5ea02fbbb01543.diff

LOG: [libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc

This one already had a proper explanation why it fails, which is due to
differences by design in MSVC mode. This isn't a fixme, so degrade the
annotation to a more permanent "XFAIL: msvc" instead.

Differential Revision: https://reviews.llvm.org/D107758

Added: 
    

Modified: 
    libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
index 9017471fede7d..080731f56e2b9 100644
--- a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
+++ b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
@@ -7,8 +7,8 @@
 //===----------------------------------------------------------------------===//
 
 // This test fails because diagnose_if doesn't emit all of the diagnostics
-// when -fdelayed-template-parsing is enabled, like it is on Windows.
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// when -fdelayed-template-parsing is enabled, like it is in MSVC mode.
+// XFAIL: msvc
 
 // REQUIRES: diagnose-if-support
 // UNSUPPORTED: libcpp-has-no-threads


        


More information about the libcxx-commits mailing list