[libcxx-commits] [PATCH] D107801: Remove unused include in <compare>.

[Kent Ross via Phabricator via libcxx-commits]

mumbleskates created this revision.
mumbleskates added reviewers: ldionne, Mordante, zoecarver, cjdb.
mumbleskates requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

`<type_traits>` was included in the first iteration of `<compare>` when it was created as a monolithic header, then never removed. Removing it now is a beneficial no-op since it is not guaranteed by the standard and is already included by all of its subheaders.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107801

Files:
  libcxx/CREDITS.TXT
  libcxx/include/compare


Index: libcxx/include/compare
===================================================================
--- libcxx/include/compare
+++ libcxx/include/compare
@@ -123,7 +123,6 @@
 #include <__compare/common_comparison_category.h>
 #include <__compare/ordering.h>
 #include <__config>
-#include <type_traits>
 
 #ifndef _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER
 #pragma GCC system_header
Index: libcxx/CREDITS.TXT
===================================================================
--- libcxx/CREDITS.TXT
+++ libcxx/CREDITS.TXT
@@ -113,6 +113,10 @@
 E: jroelofS at jroelofs.com
 D: Remote testing, Newlib port, baremetal/single-threaded support.
 
+N: Kent Ross
+E: k at mad.cash
+D: C++20 language feature support
+
 N: Jonathan Sauer
 D: Minor patches, mostly related to constexpr
 
@@ -149,11 +153,11 @@
 E: xingxue at ca.ibm.com
 D: AIX port
 
-N: Zhihao Yuan
-E: lichray at gmail.com
-D: Standard compatibility fixes.
-
 N: Jeffrey Yasskin
 E: jyasskin at gmail.com
 E: jyasskin at google.com
 D: Linux fixes.
+
+N: Zhihao Yuan
+E: lichray at gmail.com
+D: Standard compatibility fixes.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107801.365349.patch
Type: text/x-patch
Size: 1058 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210810/c51b994c/attachment.bin>