[libcxx-commits] [PATCH] D107036: [WIP] [libc++] [P1614] Various unimplemented parts of <compare>. [WIP]
Christopher Di Bella via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Aug 9 11:27:58 PDT 2021
cjdb added a comment.
In addition to my feedback above, please drop the `<concepts>` changes from this patch (no longer necessary), as well as the changes in common with D80899 <https://reviews.llvm.org/D80899> and D80902 <https://reviews.llvm.org/D80902> (I'll return to these once `three_way_comparable` lands).
Please also ensure that what's left properly credits the original patch authors in the commit, preferably by making them the person that's named in `git blame`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107036/new/
https://reviews.llvm.org/D107036
More information about the libcxx-commits
mailing list