[libcxx-commits] [PATCH] D107712: Fix possible infinite loop in itanium demangler

[Mikhail Borisov via Phabricator via libcxx-commits]

borman added inline comments.


================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:112-229
+template <class T, size_t N>
+class PODSmallVector {
+  static_assert(std::is_pod<T>::value,
+                "T is required to be a plain old data type");
+
+  T* First = nullptr;
+  T* Last = nullptr;
----------------
ldionne wrote:
> borman wrote:
> > I could submit this change as a NFC to clean up the actual patch; however the move itself would be out of context.
> I would rather the move be performed as a separate NFC. The commit message can mention it's for a follow-up change.
Separate review for the move: https://reviews.llvm.org/D107712


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107712/new/

https://reviews.llvm.org/D107712