[libcxx-commits] [PATCH] D107758: [libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp:9-13
 // This test fails because diagnose_if doesn't emit all of the diagnostics
-// when -fdelayed-template-parsing is enabled, like it is on Windows.
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// when -fdelayed-template-parsing is enabled, like it is in MSVC mode.
+// XFAIL: msvc
 
 // REQUIRES: diagnose-if-support
----------------
Should msvc simply undefine `diagnose-if-support`?
Right now we don't have many tests that check either of these flags:
```
$ git grep msvc
std/input.output/iostreams.base/ios.base/ios.base.storage/iword.pass.cpp:// UNSUPPORTED: msvc
std/input.output/iostreams.base/ios.base/ios.base.storage/pword.pass.cpp:// UNSUPPORTED: msvc
std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp:// UNSUPPORTED: msvc
std/thread/thread.mutex/thread.lock.algorithm/lock.pass.cpp:// UNSUPPORTED: libstdc++, msvc
std/utilities/meta/meta.trans/meta.trans.other/underlying_type.fail.cpp:// UNSUPPORTED: msvc

$ git grep diagnose-if-support
libcxx/atomics/diagnose_invalid_memory_order.verify.cpp:// REQUIRES: diagnose-if-support
libcxx/containers/associative/non_const_comparator.verify.cpp:// REQUIRES: diagnose-if-support
libcxx/containers/unord/non_const_comparator.verify.cpp:// REQUIRES: diagnose-if-support
libcxx/containers/unord/unord.set/missing_hash_specialization.fail.cpp:// REQUIRES: diagnose-if-support
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107758/new/

https://reviews.llvm.org/D107758