[libcxx-commits] [PATCH] D107596: [libc++][doc] Improve contributor documentation.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with a few suggestions!



================
Comment at: libcxx/docs/Contributing.rst:73-74
+
+For features in a not yet ratified C++ Standard libc++ makes no guarantees
+about the implementation status nor the ABI stability. After the C++ Standard
+is ratified libc++ promises a conforming ABI stable implementation. When
----------------



================
Comment at: libcxx/docs/Contributing.rst:75
+about the implementation status nor the ABI stability. After the C++ Standard
+is ratified libc++ promises a conforming ABI stable implementation. When
+working on a large new feature in the ratified version of the C++ Standard that
----------------



================
Comment at: libcxx/docs/Contributing.rst:84
+disable these incomplete features, so they can promise ABI stability to their
+customers.  This is done by the CMake option
+``LIBCXX_ENABLE_INCOMPLETE_FEATURES``. When start working on a large feature
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107596/new/

https://reviews.llvm.org/D107596