[libcxx-commits] [PATCH] D107758: [libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

This one already had a proper explanation why it fails, which is due to
differences by design in MSVC mode. This isn't a fixme, so degrade the
annotation to a more permanent "XFAIL: msvc" instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107758

Files:
  libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp


Index: libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
===================================================================
--- libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
+++ libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
@@ -7,8 +7,8 @@
 //===----------------------------------------------------------------------===//
 
 // This test fails because diagnose_if doesn't emit all of the diagnostics
-// when -fdelayed-template-parsing is enabled, like it is on Windows.
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// when -fdelayed-template-parsing is enabled, like it is in MSVC mode.
+// XFAIL: msvc
 
 // REQUIRES: diagnose-if-support
 // UNSUPPORTED: libcpp-has-no-threads


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107758.365153.patch
Type: text/x-patch
Size: 730 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210809/292ddcd7/attachment.bin>