[libcxx-commits] [PATCH] D107537: ARM32 unwinding on EHABI has issues with static analysis

Andrii Kurdiumov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 4 22:43:33 PDT 2021


kant2002 created this revision.
kant2002 added a reviewer: libunwind.
kant2002 added a project: libunwind.
Herald added subscribers: libcxx-commits, kristof.beyls.
Herald added 1 blocking reviewer(s): libunwind.
kant2002 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Based on limited understanding these breaks just missing from the original submission time.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107537

Files:
  libunwind/src/Unwind-EHABI.cpp


Index: libunwind/src/Unwind-EHABI.cpp
===================================================================
--- libunwind/src/Unwind-EHABI.cpp
+++ libunwind/src/Unwind-EHABI.cpp
@@ -97,9 +97,11 @@
       case Descriptor::LU32:
         descriptor = getNextWord(descriptor, &length);
         descriptor = getNextWord(descriptor, &offset);
+        break;
       case Descriptor::LU16:
         descriptor = getNextNibble(descriptor, &length);
         descriptor = getNextNibble(descriptor, &offset);
+        break;
       default:
         assert(false);
         return _URC_FAILURE;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107537.364351.patch
Type: text/x-patch
Size: 585 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210805/d63784dd/attachment-0001.bin>


More information about the libcxx-commits mailing list