[libcxx-commits] [PATCH] D67466: [libcxx] Annotate shared_mutex with thread annotations

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 2 13:21:43 PDT 2021


phosek added a comment.

In D67466#1666937 <https://reviews.llvm.org/D67466#1666937>, @ldionne wrote:

> When are those annotations enabled? By default they're turned off, would it make sense to turn them on by default? It seems like we're missing out on something interesting here.

These are statically checked by the compiler when `_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS` is defined. I've included tests to cover the newly added annotations similarly to how we already test annotations on `std::mutex`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67466/new/

https://reviews.llvm.org/D67466



More information about the libcxx-commits mailing list