[libcxx-commits] [PATCH] D101316: [libcxx][ranges] Add `random_access_{iterator, range}`.

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 30 18:00:23 PDT 2021


cjdb requested changes to this revision.
cjdb added a comment.
This revision now requires changes to proceed.

Please add the following tests:

- subsumption for `random_access_iterator`
- subsumption for `random_access_range`
- iterator conformance tests



================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.random.access/random_access_iterator.compile.pass.cpp:56
+
+struct simple_random_access_iterator
+  : simple_bidirectional_iterator<simple_random_access_iterator> {
----------------
Please add a test for when `iterator_concept = std::bidirectional_iterator_tag`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101316/new/

https://reviews.llvm.org/D101316



More information about the libcxx-commits mailing list