[libcxx-commits] [PATCH] D100275: [libcxx][iterator][ranges] adds `forward_iterator` and `forward_range`

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 30 17:18:18 PDT 2021


cjdb added inline comments.


================
Comment at: libcxx/test/support/test_iterators.h:671
+template <class I>
+struct cxx20_forward_iterator {
+  using value_type = std::iter_value_t<I>;
----------------
ldionne wrote:
> I thought we had that discussion before, but why are we adding this type? Why can't we use just the existing `forward_iterator`? They are not materially different.
Whoops, I forgot to delete this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100275/new/

https://reviews.llvm.org/D100275



More information about the libcxx-commits mailing list