[libcxx-commits] [PATCH] D101679: [libc++] [LIBCXX-DEBUG-FIXME] Stop using invalid iterators to insert into sets/maps.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, howard.hinnant, libc++.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

  This simply applies Howard's commit 4c80bfbd53caf consistently
  across all the associative and unordered container tests.
  
  "unord.set/insert_hint_const_lvalue.pass.cpp" failed with `-D_LIBCPP_DEBUG=1`
  before this patch; it was the only one that incorrectly reused
  invalid iterator `e`. The others already used valid iterators
  (generally `c.end()`); I'm just making them all match the same pattern
  of usage: "e, then r, then c.end() for the rest."


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101679

Files:
  libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/insert_hint_const_lvalue.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/insert_hint_rvalue.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/insert_hint_const_lvalue.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/insert_hint_const_lvalue.pass.cpp
  libcxx/test/std/containers/unord/unord.set/insert_hint_const_lvalue.pass.cpp
  libcxx/test/std/containers/unord/unord.set/insert_hint_rvalue.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101679.342091.patch
Type: text/x-patch
Size: 5903 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210501/086d989e/attachment.bin>