[libcxx-commits] [PATCH] D100866: Add a buildkite for _LIBCPP_DEBUG=1.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM and I don't want to be unproductive so I'll let it slip, but it still seems to me that it would be more consistent to use

  export CC=clang
  export CXX=clang++

And if we really want to be using ToT Clang here, then perhaps we should consider using ToT everywhere instead, and adding a single job that tests on an "older" compiler, as a means of testing that we still support those older compilers. Actually, after writing that, I think it would make sense to do it as part of the patch that will explain our compiler support policy, which I still need to write.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100866/new/

https://reviews.llvm.org/D100866