[libcxx-commits] [PATCH] D101565: [libcxx] [ci] Add a Windows CI configuration for a statically linked libc++

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Adding this job LGTM, I'd like it written a bit differently (if my suggestions make sense).



================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:321
+  - label: "Windows (DLL)"
+    command: "bash libcxx/utils/ci/run-buildbot win-dll"
+    artifact_paths:
----------------
Please use `windows-dll` instead of `win-dll`. Same for `-static`.


================
Comment at: libcxx/utils/ci/run-buildbot:97-108
+    echo "--- Generating CMake"
+    cmake -S "${MONOREPO_ROOT}/libcxx" \
+          -B "${BUILD_DIR}" \
+          -GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \
+          -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+          -DCMAKE_C_COMPILER=clang-cl \
+          -DCMAKE_CXX_COMPILER=clang-cl \
----------------
Could we instead do this to reuse as much between the Windows and non-Windows cases? I'm a bit worried that the two invocations are going to diverge with time.

```
generate-cmake -DCMAKE_CXX_FLAGS="-D_LIBCPP_HAS_NO_INT128" \
                   -DLIBCXX_TEST_COMPILER_FLAGS="-D_LIBCPP_HAS_NO_INT128" \
                   -DLIBCXX_ENABLE_FILESYSTEM=YES
```

Then, from below:

```
export CC=clang-cl
export CXX=clang-cl
generate-cmake-libcxx-windows -DOPTIONS
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101565/new/

https://reviews.llvm.org/D101565