[libcxx-commits] [PATCH] D101613: [libcxx] Reenable ranges for clang-cl

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

LGTM % alphabetization



================
Comment at: libcxx/test/support/nasty_macros.h:56-68
 #ifndef _WIN32
 #define __allocator NASTY_MACRO
 #define __deallocate NASTY_MACRO
 #define __out NASTY_MACRO
+#define __in NASTY_MACRO
+#define __inout NASTY_MACRO
+#define __opt NASTY_MACRO
----------------
Please alphabetize. (So that the next person to add an identifier here doesn't have to make any decisions about where to put it "thematically" — it'll be a nice mechanical decision. Plus easy to check for duplicates.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101613/new/

https://reviews.llvm.org/D101613