[libcxx-commits] [PATCH] D100278: [libcxx][iterator][ranges] adds `bidirectional_iterator` and `bidirectional_range`

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Mostly LGTM, with minor nits.



================
Comment at: libcxx/test/std/containers/sequences/array/range_concept_conformance.compile.pass.cpp:30
 static_assert(stdr::common_range<range const>);
-static_assert(stdr::forward_range<range const>);
+static_assert(stdr::bidirectional_range<range const>);
----------------
Shouldn't we keep both the assertions for `forward_range` and `bidirectional_range`? (here and everywhere else)


================
Comment at: libcxx/test/support/test_iterators.h:699
+template <class I>
+struct cxx20_bidirectional_iterator {
+  using value_type = std::iter_value_t<I>;
----------------
To remove IIUC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100278/new/

https://reviews.llvm.org/D100278