[libcxx-commits] [PATCH] D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings

[Sean Fertile via Phabricator via libcxx-commits]

sfertile added a comment.

In D101545#2726036 <https://reviews.llvm.org/D101545#2726036>, @MaskRay wrote:

> I keep feeling that the AIX implementation probably needs its own file. Making Itanium/ARM/SEH share some functions actually make generic code improvement harder.

I agree on the second part, but I don't think AIX should be split out to separate files. The AIX range table implementation which this change is meant to enable, from what I understand, is a completely straight-forward implementation of Itanium using DW_EH_PE_datarel. We would essentially be duplicating all the Itanium code for AIX with only a handful of differing lines. Splitting ARM and SEH into distinct files from Itanium might be useful, but we still need to make this exact change to the Itanium implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101545/new/

https://reviews.llvm.org/D101545