[libcxx-commits] [PATCH] D101550: [libcxx] Use shell quoting for include flag on Windows

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 29 10:32:05 PDT 2021


phosek added a comment.

In D101550#2726176 <https://reviews.llvm.org/D101550#2726176>, @mstorsjo wrote:

> Can you explain the issue, including the circumstances where/when the issue occurs, in a bit more detail, I don't quite follow. (We do have CI for windows, in an msvc setting, so it works in some configs at least.)

See the last paragraph on https://cmake.org/cmake/help/v3.13/command/target_compile_options.html, I'll add it to the description as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101550/new/

https://reviews.llvm.org/D101550



More information about the libcxx-commits mailing list