[libcxx-commits] [PATCH] D101206: [libc++] Remove UB in std::list
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Apr 29 08:40:26 PDT 2021
EricWF added a comment.
In D101206#2721174 <https://reviews.llvm.org/D101206#2721174>, @akhuang wrote:
> Seems like it's a little less straightforward for some of the other types (`__tree_node`, `__value_type` and `__hash_value_type`), especially since they explicitly delete the constructors/destructors and I don't have a great understanding of why. Should probably get @EricWF's opinion on this?
>
> I'm still somewhat leaning toward just adding an attribute to those types to solve the debug info issue (https://reviews.llvm.org/D98750)
I agree that the attribute is a non-complicated and good way to address those types.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101206/new/
https://reviews.llvm.org/D101206
More information about the libcxx-commits
mailing list