[libcxx-commits] [PATCH] D101434: [libcxx] [test] Include more libraries that normally are linked automatically

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 28 10:57:02 PDT 2021


mstorsjo added a comment.

In D101434#2723346 <https://reviews.llvm.org/D101434#2723346>, @Mordante wrote:

> This SGTM, but I see the Runtimes build fails. Can you verify this has nothing to do with this patch?

It's pretty certainly unrelated, as this patch only touches windows specific codepaths, and there were similar spurious breakage in D101437 <https://reviews.llvm.org/D101437> (both ran on top of the same llvm-project commit). I can of course put it another round through CI before pushing...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101434/new/

https://reviews.llvm.org/D101434



More information about the libcxx-commits mailing list