[libcxx-commits] [PATCH] D100275: [libcxx][iterator][ranges] adds `forward_iterator` and `forward_range`

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

LGTM except the testing bits.



================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.forward/forward_iterator.compile.pass.cpp:28
+
+// TODO: add new `cxx20_*_iterator`s as they're added
+static_assert(!std::forward_iterator<cxx20_input_iterator<int*> >);
----------------
This should be removed with the new direction IIUC.


================
Comment at: libcxx/test/support/test_iterators.h:671
+template <class I>
+struct cxx20_forward_iterator {
+  using value_type = std::iter_value_t<I>;
----------------
I thought we had that discussion before, but why are we adding this type? Why can't we use just the existing `forward_iterator`? They are not materially different.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100275/new/

https://reviews.llvm.org/D100275