[libcxx-commits] [PATCH] D101371: [libcxx][ranges] Fix tests for stdlib types that conform to sized_sentinel_for.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

Ship it, since it fixes typos in the tests.

But, like, //none// of these tests are useful, IMO. It's arguably useful to test in //one// place (namely in the `reverse_iterator` tests) that `declval<T>() == declval<reverse_iterator<T>>()` is SFINAE-friendly ill-formed; but testing it indirectly, via the same 4 copied lines, pasted among 10 different container tests, and only tested in C++20 mode, is not so useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101371/new/

https://reviews.llvm.org/D101371