[libcxx-commits] [PATCH] D101420: [libc++] [test] Don't assume iterators are class types.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 27 18:33:43 PDT 2021


Quuxplusone created this revision.
Quuxplusone added reviewers: libc++, zoecarver.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

  In particular, `span<int>::iterator` may be a raw pointer type
  and thus have no nested typedef `iterator::value_type`. However,
  we already know that the value_type we expect for `span<int>` is just `int`.
  Fix up all other iterator_concept_conformance tests in the same way.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101420

Files:
  libcxx/test/std/containers/associative/map/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/associative/multimap/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/associative/multiset/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/associative/set/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/sequences/deque/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/forwardlist.iter/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/sequences/list/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/sequences/vector.bool/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/sequences/vector/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/unord/unord.map/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/unord/unord.set/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/containers/views/span.iterators/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/input.output/filesystems/class.directory_iterator/iterator_concept_conformance.compile.pass.cpp
  libcxx/test/std/iterators/iterator.requirements/iterator.assoc.types/readable.traits/iter_value_t.pass.cpp
  libcxx/test/std/strings/basic.string/string.iterators/iterator_concept_conformance.compile.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101420.341050.patch
Type: text/x-patch
Size: 14002 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210428/9e437e1c/attachment-0001.bin>


More information about the libcxx-commits mailing list