[libcxx-commits] [PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

Tue Apr 27 13:43:42 PDT 2021

bjope added a comment.

In D101194#2720787 <https://reviews.llvm.org/D101194#2720787>, @phosek wrote:

> In D101194#2720761 <https://reviews.llvm.org/D101194#2720761>, @bjope wrote:
>
>> Or maybe the problem is that we use `-DLLVM_BUILTIN_TARGETS=default`?
>
> The use of `default` is the issue, the problem is that the target triple "guessed" by `config.guess` doesn't necessarily match the multiarch triple used by Clang. I think that ideally we would stop relying on `LLVM_DEFAULT_TARGET_TRIPLE` and instead we would get the path directly from Clang. I can look into it but that might take a while to implement so we should probably revert the change for now?
>
> I'm a bit surprised that you're using `-DLLVM_BUILTIN_TARGETS=default` but `-DLLVM_RUNTIME_TARGETS='x86_64-linux-gnu'`, usually I'd expect these to match.

Well, maybe that is for historical reasons. Or our downstream branch we use more targets, but I guess we got some problems on the main branch at some time and limited LLVM_RUNTIME_TARGETS to only do x86_64 (while normally we also build i386). And  LLVM_BUILTIN_TARGETS=default happens to produce both x86_64 and i386 builtins.

Anyway I've tried changing to LLVM_BUILTIN_TARGETS='x86_64-linux-gnu' (and also LLVM_BUILTIN_TARGETS='i386-linux-gnu;x86_64-linux-gnu') and that seems to work fine. So I think I'm back on track. Thanks!
(Crossing my fingers and hopefully I'll get things working on the downstream branch with additional downstream targets.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101194/new/

https://reviews.llvm.org/D101194