[libcxx-commits] [PATCH] D100219: [libcxx] [test] Skip alloc counter checks for operations within the libc++ DLL

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.concat.pass.cpp:144-146
+  // In DLL builds on Windows, the overridden operator new won't pick up
+  // allocations done within the DLL, so the RequireAllocationGuard below
+  // won't necessarily see allocations in the cases where they're expected.
----------------
Should this be considered a bug in the Windows runtime? If so, it's not doing any good to work around it in our test suite, we should instead:
1. File a bug report to get it fixed, and
2. Mark the whole test as being broken until they fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100219/new/

https://reviews.llvm.org/D100219