[libcxx-commits] [PATCH] D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel

Sean Fertile via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 26 18:10:02 PDT 2021


sfertile added inline comments.


================
Comment at: libcxxabi/src/cxa_personality.cpp:91
 +----------------------------------------------------------------------------------+
-#endif // __USING_SJLJ_EXCEPTIONS__
+#endif  // __USING_SJLJ_EXCEPTIONS__
 +---------------------------------------------------------------------+
----------------
errant whitespace change.


================
Comment at: libcxxabi/src/cxa_personality.cpp:249
-{
-    uintptr_t result = 0;
-    if (encoding == DW_EH_PE_omit)
----------------
I'm guessing these indentation changes, and brace placement changes are from clang format, but it no longer matches the formatting of the rest of the file. We shouldn't be changing formatting on otherwise untouched lines, and the changes we do make should match the formatting of the rest of the file. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101298/new/

https://reviews.llvm.org/D101298



More information about the libcxx-commits mailing list