[libcxx-commits] [PATCH] D100775: Support leak sanitizer in libcxx.

[Sterling Augustine via Phabricator via libcxx-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGfe1555607716: Support leak sanitizer in libcxx. (authored by saugustine).

Changed prior to commit:
  https://reviews.llvm.org/D100775?vs=338561&id=340646#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100775/new/

https://reviews.llvm.org/D100775

Files:
  libcxx/test/libcxx/gdb/gdb_pretty_printer_test.py
  libcxx/utils/libcxx/test/config.py


Index: libcxx/utils/libcxx/test/config.py
===================================================================
--- libcxx/utils/libcxx/test/config.py
+++ libcxx/utils/libcxx/test/config.py
@@ -526,6 +526,8 @@
                 self.config.available_features.add('sanitizer-new-delete')
             elif san == 'DataFlow':
                 self.cxx.flags += ['-fsanitize=dataflow']
+            elif san == 'Leaks':
+                self.cxx.link_flags += ['-fsanitize=leaks']
             else:
                 self.lit_config.fatal('unsupported value for '
                                       'use_sanitizer: {0}'.format(san))
Index: libcxx/test/libcxx/gdb/gdb_pretty_printer_test.py
===================================================================
--- libcxx/test/libcxx/gdb/gdb_pretty_printer_test.py
+++ libcxx/test/libcxx/gdb/gdb_pretty_printer_test.py
@@ -37,23 +37,6 @@
             compare_frame = gdb.newest_frame().older()
             testcase_frame = compare_frame.older()
             test_loc = testcase_frame.find_sal()
-
-            expectation_val = compare_frame.read_var("expectation")
-            check_literal = expectation_val.string(encoding="utf-8")
-
-            # Heuristic to determine if libc++ itself has debug
-            # info. If it doesn't, then anything normally homed there
-            # won't be found, and the printer will error. We don't
-            # want to fail the test in this case--the printer itself
-            # is probably fine, or at least we can't tell.
-            if check_literal.startswith("std::shared_ptr"):
-                shared_ptr = compare_frame.read_var("value")
-                if not "__shared_owners_" in shared_ptr.type.fields():
-                    print("IGNORED (no debug info in libc++): " +
-                          test_loc.symtab.filename + ":" +
-                          str(test_loc.line))
-                    return
-
             # Use interactive commands in the correct context to get the pretty
             # printed version
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100775.340646.patch
Type: text/x-patch
Size: 2031 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210426/88c88644/attachment.bin>