[libcxx-commits] [PATCH] D101316: [libcxx][ranges] Add `random_access_{iterator, range}`.

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

Looking at the list of files, we need to:

- replace `bidirectional_iterator` with `random_access_iterator` for random-access iterators in all `iterator_concept_conformance.compile.cpp`
- add a test for all the ranges that are not `random_access_range`s (and similarly for any `bidirectional_iterator`s that aren't random-access)



================
Comment at: libcxx/test/std/containers/sequences/array/range_concept_conformance.compile.pass.cpp:32
 static_assert(stdr::bidirectional_range<range const>);
+static_assert(stdr::random_access_range<range const>);
----------------
Please replace the `bidirectional_range` test.


================
Comment at: libcxx/test/std/re/re.results/range_concept_conformance.compile.pass.cpp:26
 static_assert(stdr::bidirectional_range<std::cmatch>);
+static_assert(stdr::bidirectional_range<std::cmatch>);
 
----------------
This should be `!random_access_range`, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101316/new/

https://reviews.llvm.org/D101316