[libcxx-commits] [PATCH] D101242: [libcxx][nfc] renames test iterator types to `legacy_*_iterator`

Mon Apr 26 10:14:36 PDT 2021

ldionne added a comment.

In D101242#2717210 <https://reviews.llvm.org/D101242#2717210>, @ldionne wrote:

> I agree this is making names longer and I dislike that. However, I think being able to distinguish between an archetype for a C++20 `input_iterator` and a pre-concepts `InputIterator` archetype is useful and necessary in the test suite, since those two concepts are different (see note about equality comparable https://en.cppreference.com/w/cpp/iterator/input_iterator).

@cjdb Are the other iterator concepts also different between C++20 and C++17? It's true for input iterators, but is it also the case for e.g. forward iterator? I think that should influence what we do here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101242/new/

https://reviews.llvm.org/D101242