[libcxx-commits] [PATCH] D100866: Add a buildkite for _LIBCPP_DEBUG=1.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 26 09:55:25 PDT 2021


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

@Quuxplusone

> I want to make sure that we're testing new features as soon as they're pull-requested; testing only C++14 mode wouldn't have caught the issues with <span>. Of course we could add debug-mode testing for multiple versions, like std=c++03 AND std=c++2b and maybe something in between; I thought that was overkill, but I'd do it if you want it.

We agree that testing only C++14 is bad by default, but that's not what we do. By default, the Lit configuration will test the latest supported standard anyway. I think we should have a single job with the debug mode enabled, and that job should *not* mention what standard version it's using (it should use the default one).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100866/new/

https://reviews.llvm.org/D100866



More information about the libcxx-commits mailing list