[libcxx-commits] [PATCH] D100271: [libcxx][iterator][ranges] adds `input_iterator` and `input_range`

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver accepted this revision as: zoecarver.
zoecarver added a comment.

LGTM.



================
Comment at: libcxx/test/support/test_iterators.h:638
+template <class I>
+struct cxx20_input_iterator {
+  using value_type = std::iter_value_t<I>;
----------------
Side note: I know we sort of already started down the road of `cxx20_` naming, but part of me doesn't really like this, because hopefully (and probably) this will just be "The Future of Iterators" so it would be great if we could name the other iterators "legacy" or whatever and make these new iterators seem as though they aren't the alternative. I don't know if this is feasible, or worth of the time it might cost, though. 


================
Comment at: libcxx/test/support/test_macros.h:321
+#if !defined(_LIBCPP_HAS_NO_RANGES)
+#define TEST_SUPPORTS_RANGES
+#endif
----------------
😍


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100271/new/

https://reviews.llvm.org/D100271