[libcxx-commits] [PATCH] D101183: [libc++] Make sure __bit_iterator does not use deprecated SMF generation

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 26 05:42:49 PDT 2021


ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/include/__bit_reference:1118
+    // When _IsConst=false, this is the copy constructor.
+    // It is non-trivial. We maintain this for ABI purposes.
     _LIBCPP_INLINE_VISIBILITY
----------------
Maybe mention the obvious:
> When `_IsConst=true`, the copy-constructor is the default compiler-generated one, which is trivial.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101183/new/

https://reviews.llvm.org/D101183



More information about the libcxx-commits mailing list