[libcxx-commits] [PATCH] D100269: [libcxx][ranges] adds `ranges::range`, `ranges::common_range`, and range aliases

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__ranges/concepts.h:43
+using range_difference_t = iter_difference_t<iterator_t<R> >;
+
+template <range R>
----------------
cjdb wrote:
> Mordante wrote:
> > Shouldn't
> > ```
> > template<sized_­range R>
> >     using range_size_t = decltype(ranges::size(declval<R&>()));
> > ```
> > be included here? Or is it somewhere else? If it's somewhere else can you add a comment like you did for `iterator_t`?
> Please see the commit message.
I see, missed that during the original review.


================
Comment at: libcxx/test/std/containers/associative/map/range_concept_conformance.compile.pass.cpp:12
 // UNSUPPORTED: gcc-10
 // XFAIL: msvc && clang
 
----------------
Not too fond of this, see my post-commit comments for D101205.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100269/new/

https://reviews.llvm.org/D100269