[libcxx-commits] [PATCH] D101098: [libcxx][docs] Add section for header layout and guidlines.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 24 07:03:50 PDT 2021


Mordante added a comment.

I like the shape this patch takes. Before approving I like to see all review comments addressed.



================
Comment at: libcxx/docs/Contributing.rst:69
+  (note the double underscore mangling of the parent directory only and the ``.h`` file extension on the ``<featurename>.h`` header).
+  ``toplevelheadername`` must be the exact name of whatever header the Standard requires
+  to contain this feature, e.g. ``string`` or ``ranges`` or ``memory``. ``featurename``
----------------
s/whatever/the/, sounds better IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101098/new/

https://reviews.llvm.org/D101098



More information about the libcxx-commits mailing list