[libcxx-commits] [PATCH] D101205: [libcxx] disables ranges for clang-cl

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/include/__config:851
 
-#if _LIBCPP_STD_VER <= 17 || defined(_LIBCPP_HAS_NO_CONCEPTS)
+#if _LIBCPP_STD_VER <= 17 || defined(_LIBCPP_HAS_NO_CONCEPTS) || defined(_MSC_VER)
 #define _LIBCPP_HAS_NO_RANGES
----------------
zoecarver wrote:
> Will this catch "normal" msvc too? 
Yes, it will. Currently, building libc++ with normal msvc isn't supported at all. Building libc++ with clang-cl but calling it from normal msvc probably is affected though, but I'm not sure how common that is. If needed we can make it more precise with `&& defined(__clang__)` later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101205/new/

https://reviews.llvm.org/D101205