[libcxx-commits] [PATCH] D89495: [libc++] Use the internal Lit shell to run the tests

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

Awesome!

For some reason, when I've tried running this, in addition to run-error.sh.cpp and run-success.sh.cpp, using the internal shell also broke libcxx/test/libcxx/selftest/additional_compile_flags/substitutes-in-compil
e-flags.sh.cpp in the Windows CI configuration - I haven't figured out why yet.



================
Comment at: libcxx/utils/libcxx/test/format.py:241
             steps = [
-                "%dbg(COMPILED WITH) ! %{cxx} %s %{flags} %{compile_flags} -fsyntax-only"
+                "%dbg(COMPILED WITH) not %{cxx} %s %{flags} %{compile_flags} -fsyntax-only"
             ]
----------------
These changes shouldn't be necessary any longer, ditto below on line 252 and 283


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89495/new/

https://reviews.llvm.org/D89495