[libcxx-commits] [PATCH] D101098: [libcxx][docs] Add section for header layout and guidlines.

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 22 12:04:54 PDT 2021


cjdb accepted this revision.
cjdb added a comment.

LGTM, possibly add another bullet point saying that tiny elements don't get their own header (e.g. the contents of `<type_traits>` won't be split into loads of tiny headers with exactly one query or modifier and its shorthand).



================
Comment at: libcxx/docs/Contributing.rst:72-74
+* Headers should contain specific features. A header such as ``__detail/utils.h`` might
+  turn into a dumping ground for "random" utilities. This is counterproductive and actually
+  makes things harder to find.
----------------
I think a bit more justification on why this is undesirable is necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101098/new/

https://reviews.llvm.org/D101098



More information about the libcxx-commits mailing list